Jung/staking #69
Open
Jung/staking #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prateekreddy
commented
Oct 7, 2024
| _verifyProof(_jobId, _proof); | ||
|
|
||
| uint256 feePaid = jobs[_jobId].feePaid; | ||
| uint256 pendingInflationReward = _updateInflationReward(jobs[_jobId].operator); |
There was a problem hiding this comment.
This function should probably be part of rewardManager or stakingManager.
| if (operatorJobCompletionEpochs[_operator].length == 0) return 0; | ||
|
|
||
| // list of epochs in which operator has completed jobs | ||
| uint256[] storage completedEpochs = operatorJobCompletionEpochs[_operator]; |
There was a problem hiding this comment.
The array size for an operator will always be 1. Because in the next epoch, if there was some job completed then the distribution happens right? Is there a way apart from job completion when this is updated?
There was a problem hiding this comment.
I don't understand why it always becomes 0.
Current epoch number gets pushed into the array if the last element of the array isn't current epoch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.